search

codymikol / karma-webpack

Karma webpack Middleware
MIT License
830 stars 222 forks source link

fix(karma-webpack): don't include the file extension (`output.filename`) #346

Closed Havunen closed 6 years ago

Havunen commented 6 years ago

This PR contains a bug fix

https://github.com/webpack-contrib/karma-webpack/issues/322

jsf-clabot commented 6 years ago

CLA assistant check
All committers have signed the CLA.

michael-ciniawsky commented 6 years ago

@Havunen Please sign the CLA

edmorley commented 6 years ago

The appveyor CI run failed due to the NPM DNS issue which should now be resolved. Could someone retrigger? :-)

ryanclark commented 6 years ago

How does this work with entry files that have an extension that isn’t .js? .ts, .coffee etc.

michael-ciniawsky commented 6 years ago

Yeah, its' very weird why [name].js doesn't work with karma-webpack. I was even under the impression the extension needs to present in config.output.filename... Maybe this is a bug somewhere else in the code

ryanclark commented 6 years ago

It turns out the issue was a bit different than the filename having .js in it - I've submitted a PR (#347) that fixes the issues with it. I'm closing this as it's no longer needed, thank you though!