codymikol / karma-webpack

Karma webpack Middleware
MIT License
830 stars 222 forks source link

refactor(karma-webpack): Remove lodash from dependencies #364

Closed Chalarangelo closed 5 years ago

Chalarangelo commented 6 years ago

This PR contains a:

Motivation / Use-Case

In an attempt to remove dependencies that are barely used in popular npm packages, I have replaced lodash's clone method with an inline clone function with the same functionality. Based on that and provided that lodash is not used anywhere else in this package from what I can tell, the dependency on lodash has also been removed from package.json.

Breaking Changes

Additional Info

jsf-clabot commented 6 years ago

CLA assistant check
All committers have signed the CLA.

ryanclark commented 5 years ago

@matthieu-foucault thanks - I don't personally use lodash. I agree with your second point then I'm happy with it - also the package-lock.json does need to be committed.

Chalarangelo commented 5 years ago

Anything else?