search

codymikol / karma-webpack

Karma webpack Middleware
MIT License
830 stars 222 forks source link

fix(karma-webpack): Fix publicPath to be Windows-compatible #373

Closed matthieu-foucault closed 5 years ago

matthieu-foucault commented 5 years ago

This PR contains a:

Taking over #366 (cleaned up PR and fixed another instance of publicPath). Fixes #362 (tested using steps provided by @johnnyreilly).

Public path is a URL, not a file path. It should not be created using path.join, which uses backslashes on Windows.

jsf-clabot commented 5 years ago

CLA assistant check
All committers have signed the CLA.

johnnyreilly commented 5 years ago

Great news!

matthieu-foucault commented 5 years ago

Published on npm under karma-webpack@next

johnnyreilly commented 5 years ago

Awesome work - I'll give it a try!

https://github.com/TypeStrong/ts-loader/pull/873

johnnyreilly commented 5 years ago

All good!