fix(karma-webpack): Regression in multi-compiler mode (#390)

codymikol / karma-webpack

Karma webpack Middleware

MIT License

830 stars 222 forks source link

fix(karma-webpack): Regression in multi-compiler mode (#390) #391

Closed jakub-g closed 5 years ago

jakub-g commented 5 years ago

This fixes a regression introduced in [4.0.0-rc4] See #390 for details

jsf-clabot commented 5 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

ryanclark commented 5 years ago

If you're adding/removing dependencies, can you commit package-lock.json too please 🙂

jakub-g commented 5 years ago

Hello, I updated the PR (took a while, sorry for that) - can you check again?

For info, the build is failing with webpack_version=next config, but this is unrelated to this PR (it works with webpack_version=latest, and master alredy fails with next)

There's some unwanted diff in package-lock.json probably due to mismatch of npm versions (each version of npm generates a different lockfile, which is quite annoying...)