codymikol / karma-webpack

Karma webpack Middleware
MIT License
830 stars 222 forks source link

fix(karma-webpack): don't error when webpackMiddleware config not provided #418

Closed caseyWebb closed 5 years ago

caseyWebb commented 5 years ago

This PR contains a:

Motivation / Use-Case

Error is thrown if no webpackMiddleware. You can see here the change that makes the CI pass again.

Breaking Changes

N/A

Additional Info

Regression introduced in 4.0.0

jsf-clabot commented 5 years ago

CLA assistant check
All committers have signed the CLA.

ryanclark commented 5 years ago

Perfect thanks!

ryanclark commented 5 years ago

Seems to be stuck on the CLA check, @evilebottnawi any ideas?

alexander-akait commented 5 years ago

Sometimes it is buggy, just reopen issue

ryanclark commented 5 years ago

Nice one!