fix(karma-webpack): close `middleware` on compile `done` in `singleRu…

codymikol / karma-webpack

Karma webpack Middleware

MIT License

830 stars 222 forks source link

fix(karma-webpack): close `middleware` on compile `done` in `singleRu… #449

Closed shihabuddin closed 3 years ago

shihabuddin commented 4 years ago

…n` mode

When in singleRun mode, close the webpack dev middleware once the compilation is done. Otherwise, webpack listens to file changes and re-compiles them while the test is running.

Closes #448

This PR contains a:

[ x] bugfix
[ ] new feature
[ ] code refactor
[ ] test update
[ ] typo fix
[ ] metadata update

Motivation / Use-Case

It fixes #448

Breaking Changes

Additional Info

shihabuddin commented 4 years ago

I have created a test-pr-449 branch in the reproduce repo that uses this PR. The bug is gone there.

eschiebel commented 3 years ago

@ryanclark this fix would help me out too. Kudos for a review please.

codymikol commented 3 years ago

Hey @shihabuddin sorry for such a long wait, if you rebase this on master, I can try and get this in ASAP

shihabuddin commented 3 years ago

Thanks @codymikol.

But, there seems to be a lot of changes on master. That makes it impossible to rebase it.

I have created a test-v5 branch on the reproduce repo and upgraded karma-webpack to v5.0.0. I can't reproduce #448 any more.

codymikol commented 3 years ago

Thanks for your efforts @shihabuddin