search

codynoel / snappy

Automatically exported from code.google.com/p/snappy
Other
0 stars 0 forks source link

simpler configure.ac #33

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The following patch simplifies configure.ac and snappy-stubs-public.h.in

I'm no expert with the autotools, but I believe this change doesn't change any 
behaviour.

cheers

Original issue reported on code.google.com by fdman...@gmail.com on 16 Apr 2011 at 3:54

Attachments:

GoogleCodeExporter commented 9 years ago 
This won't work. You need to get HAVE_STDINT_H from somewhere; the usual place 
would be config.h, but you cannot include config.h in a public header file, 
since that would pull in definitions (e.g. of VERSION) that would conflict with 
other autotools-based projects' config.h.

In short, the current behavior is correct and needed.

Original comment by se...@google.com on 16 Apr 2011 at 7:37

GoogleCodeExporter commented 9 years ago 
Hum, you're right, thanks for the explanation :)

Original comment by fdman...@gmail.com on 16 Apr 2011 at 7:55

GoogleCodeExporter commented 9 years ago 
Looking at snappy.h:

http://code.google.com/p/snappy/source/browse/trunk/snappy.h#42

Unlike snappy-stubs-public.h.in, the inclusion of stddef.h is not conditional.
Isn't this a problem?

Original comment by fdman...@gmail.com on 16 Apr 2011 at 10:14

GoogleCodeExporter commented 9 years ago 
stddef.h should always be available (by the C standard), as far as I know, so I 
think the HAVE_ for stddef.h is redundant. The other header isn't.

Original comment by se...@google.com on 16 Apr 2011 at 10:48