search

codyopel / collide

Automatically exported from code.google.com/p/collide
Apache License 2.0
0 stars 0 forks source link

ant build test fails for clean build due to expecting a directory to exist #24

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. git pull the project
2. ant dist
3. ant build test

What is the expected output? What do you see instead?
a completed compilation of all the tests, instead it fails with the message:

BUILD FAILED
/home/alusco/Documents/collide/javatests/com/google/collide/server/api/build.xml
:13: Directory does not exist: 
/home/alusco/Documents/collide/bin/test/classes/com/google/collide/server/api

Line 13 is this:
<!-- Clean up the destination so we know exactly what's there.
         Otherwise, prior test runs might leave junk. -->
<delete includeemptydirs="true">
  <fileset dir="${api_tests.out}" includes="**/*"/>
</delete>

In the case of never building the tests before the directory 
bin/test/classes/com/google/collide/server and 
bin/test/classes/com/google/collide/server/api do not exist so it seems like 
the delete rule fails.

Workaround:
just mkdir bin/test/classes/google/collide/server then mkdir 
bin/test/classes/com/google/collide/server/api

This occurs on ubuntu lucid 10.04

Original issue reported on code.google.com by alex.lu...@gmail.com on 9 Jul 2012 at 7:34

GoogleCodeExporter commented 9 years ago 
going to add a cc of freeland (also going to see if I can figure out how to fix 
it myself)

Original comment by alex.lu...@gmail.com on 9 Jul 2012 at 7:35

GoogleCodeExporter commented 9 years ago 
so what's the code-review policy :)  I've attached a patch but not sure what

Original comment by alex.lu...@gmail.com on 9 Jul 2012 at 7:49

Attachments:

GoogleCodeExporter commented 9 years ago 
didn't finish my sentence lol -- not sure what... the protocol is for doing 
something.  So after someone takes a look do you just push?

Original comment by alex.lu...@gmail.com on 9 Jul 2012 at 7:50

GoogleCodeExporter commented 9 years ago 
One more thing, also should I be cc'ing a mailing list of some kind 
/endnewbquestions

Original comment by alex.lu...@gmail.com on 9 Jul 2012 at 7:50

GoogleCodeExporter commented 9 years ago 
Patch LGTM.

To answer your question, I wrote this doc: 
http://code.google.com/p/collide/wiki/SubmittingChanges

Original comment by dragonsinth on 9 Jul 2012 at 3:04

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision 36153fc60725.

Original comment by alex.lu...@gmail.com on 12 Jul 2012 at 12:07