Underscores not displayed properly by the code editor

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Open a file in the collide editor window
2. Find a line that includes an underscore, or type one

What is the expected output? What do you see instead?

You should see an underscore character.

What version of the product are you using? On what operating system?

Latest collide server running on Ubuntu 12.04. The client is Windows 7 on 
Chrome version 20.0.1132.43 beta-m

Original issue reported on code.google.com by fro...@frozen-solid.net on 9 Jul 2012 at 7:08

[GoogleCodeExporter]

Couldn't repro-- I see underscores.  What type of file are you editing?

Original comment by dragonsinth on 11 Jul 2012 at 5:10

[GoogleCodeExporter]

I was editing a PHP file.

Original comment by fro...@frozen-solid.net on 11 Jul 2012 at 7:01

[GoogleCodeExporter]

An example is this file: 
http://framework.zend.com/svn/framework/standard/trunk/library/Zend/Mail/Part.ph
p

I attached a screenshot of the bug.

Original comment by fro...@frozen-solid.net on 11 Jul 2012 at 2:32

Attachments:

• collide.png

[GoogleCodeExporter]

I also experience the exact problem when creating a new file the underscore 
does not appear on Windows Chrome but on OSX Chrome I do see the _ character.

Original comment by ma...@goidx.com on 11 Jul 2012 at 6:56

[GoogleCodeExporter]

Very strange.  I'm on Windows XP, with Chrome 21.0.1180.15 beta-m.  I see the 
underscores just fine in a PHP file. :(

Someone who can repro this: please poke around with the DOM inspector and 
figure out what's going on.

CC: jason, who knows something about the editor's rendering

Original comment by dragonsinth on 11 Jul 2012 at 8:17

[GoogleCodeExporter]

Reproed and inspected: The monospace font on Windows 7 places the underscore 
very low.  The font size of each line is 13px and height/line-height is 15px 
(from client/editor/constants.css) but the underscore still gets hidden.

Either:
1) It can be 16px on Windows, or
2) Use the FontDimensionsCalculator's calculated height (there's a TODO in the 
code to do this).  But, this is a little bit more involved since there are CSS 
files that use the value defined in constants.css.

Original comment by jasonpar...@gmail.com on 11 Jul 2012 at 9:02

[GoogleCodeExporter]

Glad you repro'd!  It sounds like you're the right owner then?

Original comment by dragonsinth on 11 Jul 2012 at 9:18

• Changed state: Accepted

[GoogleCodeExporter]

Glad you repro'd!  It sounds like you're the right owner then?

Original comment by dragonsinth on 11 Jul 2012 at 9:19

[GoogleCodeExporter]

well that sounds icky.  I'll try to poke around at this too.  Changing up to 
use the font dimensions calculator height would be pretty tough to do simply 
(which is why I left it a TODO lol).  Maybe we can figure something else out 
then, or simply make the height of lines 16px on windows for simplicities sake. 
 If I can I'll take a look though since its weird that on Windows the _ is so 
low :/

Original comment by alex.lu...@gmail.com on 16 Jul 2012 at 5:39