codyopel / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

Flexibility in file naming options #274

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Enhancement request:

Currently GRIP and ABCDE allow the option to have filenames to be lowercase
and replace spaces with underscores.  For example the album "Shake Away" by
"Lila Downs" would be "shake_away" and "lila downs" respectively. 
Individual song titles would follow the same convention. This makes it
easier to use locate and find without needing to be concerned with spaces
and case issues.

It would be nice if rubyripper could allow the same option for those who
wish to migrate from those applications. 

Original issue reported on code.google.com by gbc...@gmail.com on 31 Jan 2009 at 2:45

GoogleCodeExporter commented 9 years ago
I use a simple policy when accepting new requests. If it's usefull for 
everyone, it
won't be an option but a default. If it's usefull for at least 5% of the users 
it
will be an option. Anything less than that, you have to apply a patch for 
yourself.

The reason for this is that I don't want 100 options. That's not user friendly 
and
not easy to maintain as well. If I look at for example grip, I am always 
horrified by
the enormous amount of options you don't need 99% of the time.

You can use this patch. But it won't be included in the mainline.

Original comment by rubyripp...@gmail.com on 31 Jan 2009 at 9:43

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the quick response and the patch!  

I think you'll find as the usage of this application becomes more widespread the
ability to control the characteristics of the file naming will be a more 
requested
option.  I did a quick google and found someone asking about this ability in an
ubuntu forum.  

http://ubuntuforums.org/archive/index.php/t-297291.html
http://ubuntuforums.org/archive/index.php/t-959109.html

Most people for whatever reason don't take the time to fill out bug/enhancement
requests.  

Again, thanks for the quick reply!

Original comment by gbc...@gmail.com on 31 Jan 2009 at 3:56

GoogleCodeExporter commented 9 years ago
I personally believe that having the option to lowercase file names and to 
replace 
spaces with underscores is a good option to include in the software by default. 
My 
argument goes that most MP3 players in Linux can only act as mass storage 
devices. It 
is quite likely that end users, such as myself, will want to transfer files to 
their 
device via the shell. Lowercased and underscored filenames make the task a tad 
less 
fiddly. In terms of thinking that GRIP has too many options, I am a little 
disappointed to hear this paradigm from the developers. I'm hoping that 
Rubyripper 
will become the champion of CD rippers for Linux, boasting all of the mature 
features 
of the top rippers for Windows plus innovation driven by the community of 
developer 
and non-developer ripping fanatics. In the end, automation is the name of the 
game 
for computers.

Original comment by martin.c...@gmail.com on 31 Jan 2009 at 4:15

GoogleCodeExporter commented 9 years ago
Actually one of the great things about rubyripper is it doesn't change the 
track 
names and add _ or lowercase ect.
If there's only to be a default it should remain as is, it's trival to edit if 
wished or use '' for paths.

Original comment by mc3...@optonline.net on 31 Jan 2009 at 4:27

GoogleCodeExporter commented 9 years ago
I feel a discussion is coming there, so I reopened the issue. You can actually 
vote
for this issue to get it on the list for to do. Adding such an option would also
require some changes to the gui and cli, so the patch is just a start.

You have to explain though, why these options are necessary. In my view the 
source of
the problem is not rubyripper's fault. No single file manager on linux has any
problems with spaces or capital letters. If you're using the wrong tools to do 
what
you want, you shouldn't blame rubyripper in my humble opinion.

Also, using the shell shouldn't be any problem since it supports space 
characters and
capital letters very well. You just need to put quotes around the argument.

So I dare you to come up with one command that won't work with spaces and/or 
capital
letters.

Original comment by rubyripp...@gmail.com on 31 Jan 2009 at 11:30

GoogleCodeExporter commented 9 years ago
Thanks for reopening and considering the issue.  I didn't mean to suggest or 
imply
that this is a code defect in rubyripper - that is why I opened as an 
enhancement
request.  

I view this as a usability/convenience option for people who are familiar with 
having
their filenames in lowercase and underscores.  File and directory names are case
sensitive and for me it is just easier to know that all my file and directory 
names
are lowercase.  That is how I store everything on my system.  I was taught to 
name
files and directories using lowercase and underscores.  Here is a weblink that 
talks
about it:
http://linux.about.com/od/linux101/l/blnewbie3_1_1.htm

Are there workarounds, sure - but as the poster phrased it about, it makes 
things "a
tad less fiddly".  

Original comment by gbc...@gmail.com on 1 Feb 2009 at 5:51

GoogleCodeExporter commented 9 years ago
I looked at the impact of the change and it bothered me it couldn't be easily 
done.
There was actually a shortcoming in my superior class model :( After some
brainstorming I started up a new class which will handle all names of the 
output dirs
and files.

The options for no spaces / capitals are there in the gui in latest git. They 
don't
do anything for now. All other classes / code will have to be ported to the new 
class
first. The overall code will improve due to the new Output class I'm sure. 
That's the
main reason I've decided to implement it.

Also, your link was a nice read ;)

Original comment by rubyripp...@gmail.com on 3 Feb 2009 at 10:16

GoogleCodeExporter commented 9 years ago
Most excellent!  Many folks will be pleased with this change.  BTW, I think it's
great the way you designed your app to be modular and support multiple 
front-ends. 
The command line interface is a nice touch also! 

Original comment by gbc...@gmail.com on 4 Feb 2009 at 1:52

GoogleCodeExporter commented 9 years ago
I'll second that - Bravo! Keep up the good work.

Original comment by martin.c...@gmail.com on 4 Feb 2009 at 2:19

GoogleCodeExporter commented 9 years ago
I'll second that too! I installed Rubyripper today and have so far used only 
the CLI;
the only thing by which I was a tiny bit disappointed was the naming policy, 
since I
have used ABCDE previously and would like to choose if the spaces are replaced 
with
underscores (and brackets removed, by the way) or not. I hope this is not a 
redundant
comment — I would just like to make clear that there are such users as I am, 
not
really "technical users / geeks" at all in a strong sense, but such that would 
like
to keep to certain well-established "standards" such as removing or replacing
cumbersome characters from file names. As a Finn whose native language has a 
couple
of very common non-UTF8 "special characters" I think I know what I'm talking 
about...

Original comment by pajari.r...@gmail.com on 4 Mar 2009 at 5:55

GoogleCodeExporter commented 9 years ago
Please take a look at this post: 
http://ubuntuforums.org/showpost.php?p=6838284&postcount=11
The thing is, on line 116 of the newly patched file we have this:

var.gsub!(' ', '_') # Replace spaces with underscores

And on line 122 we have this, on the other hand:

var.gsub!('_', ' ') # replace any underscores with spaces, some freedb info got
underscores instead of spaces

I'm an ignoramus, really, but I wonder if this is okay?

Original comment by rasaneh...@gmail.com on 4 Mar 2009 at 9:07

GoogleCodeExporter commented 9 years ago
See comment 7.  The developer is working on adding this functionality.

Original comment by gbc...@gmail.com on 4 Mar 2009 at 9:51

GoogleCodeExporter commented 9 years ago
If you have the feeling development is slow, your senses are not betrayed. It 
just
happens to be that my privat life is consuming me about 24 hours a day. Guess 
what's
left for programming :(

There is hope however. As soon as I have time I have to fix this code, 
otherwise the
whole program doesn't work with next release ;) So, have patience my friends or 
step
up to help coding :P

Original comment by rubyripp...@gmail.com on 4 Mar 2009 at 10:01

GoogleCodeExporter commented 9 years ago
At rubyripperdev, comm. # 13: Please take my comments not as negative criticism 
but
as a token of admiration for this lovely piece of software — my impatience is 
telling
of an enthusiasm in regard of good craftsmanship! As it comes to private life, 
I must
confess I accidentally (yes, I swear it was an accident!) posted from my wife's
address the comment # 11 (she read her mail and the account was left open on 
this
box... blimey!). Regarding the content of the post, I suppose (and someone
enlightened me about this probable answer) that on line 122 it is a question of 
TAGS
(metadata) while on line 116 it is question of FILE NAMES; so maybe the comments
should read e.g. more or less like this:

[line 116:] var.gsub!(' ', '_') # Replace spaces in filenames with underscores

[line 122:] var.gsub!('_', ' ') # replace any underscores in tags (metadata) 
with
spaces, some freedb info got underscores instead of spaces

Thanks again, and sorry for this babble — I can only hope I'm not just 
spamming... 

Original comment by pajari.r...@gmail.com on 4 Mar 2009 at 10:15

GoogleCodeExporter commented 9 years ago
Just an update, this is fixed in latest git. The replacement to spaces is only 
being
done if you haven't enabled the no spaces option.

Personally I wouldn't recommend current git for personal use yet. Not even for
testing purposes yet. But for testing purposes we will get there somewhere this 
week :)

Original comment by rubyripp...@gmail.com on 13 Apr 2009 at 9:28

GoogleCodeExporter commented 9 years ago
I've actually tested this thing now. It looks real ugly to my eyes, but is 
conform
your wishes. Only thing it doesn't account for is if you specify directories 
with
spaces in it to start from. All spaces will be replaced by underscores.

With the new class I've created it was simple to preserve the tags to be 
normal. Feel
free to test latest git. Though do not be scared if you encounter a crash in 
exotic
situations. It needs some serious testing still.

Watch the git log messages 
http://github.com/rubyripperdev/rubyripper/commits/master
to see if it's time to open up new bug reports against git. I will announce 
when it's
ready for some user testing.

Original comment by rubyripp...@gmail.com on 15 Apr 2009 at 5:49

GoogleCodeExporter commented 9 years ago
Issue 296 has been merged into this issue.

Original comment by rubyripp...@gmail.com on 30 Apr 2009 at 7:29

GoogleCodeExporter commented 9 years ago
When ripping books on a cd the file name should be something like 0102 where the
first two digits identify the disk and the second two identify the track.  The 
folder
identifies the book.  I have not found disks that have a three digit track 
number but
have seen them as high as 99.  If three digit track numbers are possible a five 
digit
naming scheme would be better.

Many players will go down a directory alphabetically unless you use their 
proprietary
program to make a play list. Using a naming scheme designed for music causes 
problems.

Perhaps it is possible to get such a naming scheme now, but if so I have not 
figured
out how do do so with the options allowed.

Original comment by jimfu...@comcast.net on 31 May 2009 at 3:49

GoogleCodeExporter commented 9 years ago
This request seems to be handled in a seperate issue, issue 154.

Original comment by rubyripp...@gmail.com on 31 May 2009 at 9:11