search

codypiersall / pynng

Python bindings for Nanomsg Next Generation.
https://pynng.readthedocs.io
MIT License
260 stars 58 forks source link

Remove "build-deps" user option #129

Closed mlasch closed 3 months ago

mlasch commented 3 months ago

Remove the superfluous user option "build-deps". This option which could have been used to disable building the nng and mbedtls libraries in setup.cfg.

Currently, this not possible because the if-statement checks with a logical operator instead of checking the string content.

Also, it is not clear to me, if it would even make sense to disable building the libraries, the build would fail because it does not offer an alternative like dynamically linking against a pre-compiled libnng.

In addition, using the build-deps config in setup.cfg resulted in a warning:

/tmp/build-env-u3os25k0/lib/python3.10/site-packages/setuptools/dist.py:476: SetuptoolsDeprecationWarning: Invalid dash-separated options
!!

        ********************************************************************************
        Usage of dash-separated 'build-deps' will not be supported in future
        versions. Please use the underscore name 'build_deps' instead.

        By 2024-Sep-26, you need to update your project and remove deprecated calls
        or your builds will no longer be supported.

        See https://setuptools.pypa.io/en/latest/userguide/declarative_config.html for details.
        ********************************************************************************

!!
codypiersall commented 3 months ago

Looks good, thank you! Removing unnecessary complexity always feels good.