Moved from using /bin/bash to use /bin/sh

codypiersall / pynng

Python bindings for Nanomsg Next Generation.

https://pynng.readthedocs.io

MIT License

268 stars 58 forks source link

Moved from using /bin/bash to use /bin/sh #37

Closed raphaelahrens closed 5 years ago

raphaelahrens commented 5 years ago

Since not all system have a /bin/bash installed by default it makes sense to use only /bin/sh.

Examples for OSs without default bash.

Alpine Linux
Debian
FreeBSD
NetBSD
OpenBSD
...

codypiersall commented 5 years ago

Thanks for the PR @raphaelahrens. The reason Travis failed was because of a badly written test, which I will correct after this. (The test actually implicitly relied on a race condition that shouldn't happen to happen.)

raphaelahrens commented 5 years ago

Ahh Cool and thanks.