Webserver standup - Githubissues

codyshepherd / lunar-rocks

A cooperative music generator for the web.

1 stars 0 forks source link

Webserver standup #33

Closed codyshepherd closed 5 years ago

codyshepherd commented 5 years ago

This webserver serves the contents of client/build over HTTPS on localhost:443, and comes with instructions for setting up the direnv go development environment, as well as for generating self-signed certificates for local development.

bgins commented 5 years ago

I would add a couple of things to instructions.txt:

State that you can select another directory for GOPATH if you would like
Make it clear that echo 'layout go' > .envrc is not optional and mention what it does
In the webserver instructions, mention that for local development you will need a cert and refer to local_testing.md

bgins commented 5 years ago

We may also want to add sever.crt, server.key, and maybe github.com/ and golang.org/ to .gitignore.

codyshepherd commented 5 years ago

Awesome, thanks for the review! I've updated the docs to be more complete and readable. I've also updated the .gitignore at top level.

bgins commented 5 years ago

Sweet! The documentation changes look great. I'm merging this in.