search

codysherman / 2nfm

Share your screen and computer's audio via WebRTC!
https://2n.fm
BSD 3-Clause "New" or "Revised" License
31 stars 16 forks source link

Move core-js into dev-dependency #215

Open codysherman opened 4 years ago

codysherman commented 4 years ago

Confirm whether core-js should be a dev dependecy or not, and if so, move it into the proper location and re-run yarn.

sammoore commented 4 years ago

I don't think this matters, since the project is built via Webpack (by the Vue CLI) before our code can be run anyway; core-js is loaded when the project is compiled, which implies use of other devDependencies, right? That said, given the pattern followed with other dependencies, I think it makes sense in devDependencies since it's used for polyfilling (just "compile-time overhead" to this project) and not imported directly in any source (to my knowledge).