search

codysherman / 2nfm

Share your screen and computer's audio via WebRTC!
https://2n.fm
BSD 3-Clause "New" or "Revised" License
31 stars 16 forks source link

Missing text in dark mode bug fixed #239

Closed Carlos-Gaxiola closed 2 years ago

Carlos-Gaxiola commented 2 years ago

Closes #238

Fixed the bug that didn't allow the text to change when the dark mode was activated.

Before this fix, the text stayed in the same color when the mode was switched into dark mode and it gave the impression that it had disappeared.

The underline element that marks that it is a link, had a conflict that override the class that allows to change when the dark mode is activated, so, I created a class to the underline element that applies this change.

Screen Shot 2021-12-16 at 5 31 42 p m On the component "StopSection" where this text is placed we have this underline element that has the conflict with the switch color class.

Screen Shot 2021-12-16 at 5 34 14 p m This is the class that I added to apply the change when the theme is switched

pociust commented 2 years ago

@Carlos-Gaxiola sorry for the delay in my response/review, had quite the weekend/ending of the week. I looked at the fix and it looks good, ONLY suggestion I would make is adding a transition to it so it does not just pop in. If you look at the variables.sass I believe there is a global variable ($theme-fade-speed) you can prob add to it

Carlos-Gaxiola commented 2 years ago

Nice, thank you for your time to review the PR and answering, I will be working on that suggestion :)

Carlos-Gaxiola commented 2 years ago

@Carlos-Gaxiola sorry for the delay in my response/review, had quite the weekend/ending of the week. I looked at the fix and it looks good, ONLY suggestion I would make is adding a transition to it so it does not just pop in. If you look at the variables.sass I believe there is a global variable ($theme-fade-speed) you can prob add to it

Hello, I did a commit where I added the transition.

pociust commented 2 years ago

@Carlos-Gaxiola Awesome! Sorry to nitpick here: correct fix, wrong placement. Unless you are trying to change all files (global) lets try and keep the scope local, you can prob add your css transition to the a.text-underline class you made in StopSection.vue to 1. save retyping code and 2. keep things scoped appropriately. Once you made that change/remove the global rule we should be good to go!

Carlos-Gaxiola commented 2 years ago

@Carlos-Gaxiola Awesome! Sorry to nitpick here: correct fix, wrong placement. Unless you are trying to change all files (global) lets try and keep the scope local, you can prob add your css transition to the a.text-underline class you made in StopSection.vue to 1. save retyping code and 2. keep things scoped appropriately. Once you made that change/remove the global rule we should be good to go!

Hello, thank you for your comments, I changed the placement and removed the global rule :)

Carlos-Gaxiola commented 2 years ago

Looks great, good job

Nice, thank you!