search

codysherman / 2nfm

Share your screen and computer's audio via WebRTC!
https://2n.fm
BSD 3-Clause "New" or "Revised" License
31 stars 16 forks source link

Audit bandwidth settings #73

Open codysherman opened 4 years ago

codysherman commented 4 years ago

Re-enable the settings section of the streamer page after deciding which settings should be there, and verifying what the settings actually do. Such as the bandwidth setting, what does it do, and does it actually need to be passed as a parameter.

sammoore commented 4 years ago

Could we split this up into a task to audit bandwidth (which we don't know much about / if it was working) and password (which is have an idea about and probably isn't secure) separately?

sammoore commented 4 years ago

@codysherman I believe I got the greenlight on this from you the other day, so I've split the password related work into #81, and updated this ticket to reflect just bandwidth.

sammoore commented 4 years ago

Relevant article to limiting the bandwidth via the sdp in WebRTC

codysherman commented 4 years ago

Front end UI in this branch: https://github.com/codysherman/2nfm/tree/bandwidth-slider

sammoore commented 4 years ago

I was previously using SDP munging to achieve bitrate constraints with varying success (due to different/newer encodings used, e.g. VP9).

Can't recall what RTCMultiConnection provides for stepping in during SDP negotiation, but it may be worth looking into a "new OOP method" mentioned by the SDP munging article.