search

codyswanner / Meme-Cataloger

Learning ReactJS and Django while building something that I want to use
1 stars 1 forks source link

FullScreenPictureFrame appData #117

Closed codyswanner closed 3 months ago

codyswanner commented 3 months ago

The FullScreenPictureFrame component is using a variable called "appData" that is not a precise copy of the top-level appData, and is initialized totally separately. This should have another name, as should the context provider for this stack of components.

While this is being refactored, would it be a good idea for this stack of components to have it's own separate directory as well?

codyswanner commented 3 months ago

Added an empty "appState" object to the context of this stack of components. The appData variable is initialized separately, but it contains the same data and serves the exact same function -- if it looks like a duck, talks like a duck, and uses the same data structure as a duck, must be a duck.

The empty "appState" feels a little silly, but it makes the same-name context behave the same way, and should this stack of components ever need some state shared between multiple components, there is now a convenient place to put it.