search

codyswanner / Meme-Cataloger

Learning ReactJS and Django while building something that I want to use
1 stars 1 forks source link

Add/Remove tag with filter applied breaks filter #60

Closed codyswanner closed 2 days ago

codyswanner commented 3 months ago

While a filter is applied, removing the filtered tag from an image causes the filter to break, which re-renders the page with all (unfiltered) images even though the filter still shows as applied in the filters menu. (This will all make much more sense in video form... oh look! A video!)

https://github.com/codyswanner/Meme-Cataloger2/assets/108250848/69152263-6678-43ff-9950-d9d300660478

codyswanner commented 3 months ago

Happens in the same scenario but with adding a tag rather than removing a tag.

codyswanner commented 2 days ago

This is no longer possible to replicate, as image controls (including adding/removing tags) have been moved to an entirely different page and cannot be accessed from the main page any longer. It's possible that a similar sort of bug could arise if a feature is added that allows the user to select images and add tags to a selection from the main screen -- but as of now, this bug has been squashed by other changes. Will keep an eye out for a similar bug, should it become relevant again.