search

codyswanner / Meme-Cataloger

Learning ReactJS and Django while building something that I want to use
1 stars 1 forks source link

Naming inconsistency with Tags #70

Closed codyswanner closed 2 months ago

codyswanner commented 3 months ago

In some places, the text portion of a Tag is described as the "name" of the tag, and in other places it is described as the "label" of the tag. Find these and decide one consistent scheme to describe the text portion of a tag. (Preferably, defer to what is used in the model definition in the api.models module.)

codyswanner commented 3 months ago

This problem is contained to TagPopperContent.js and consumers.py, with only about five relevant occurrences. There are more references to "label" in the code, but these are for MUI components like Autocomplete and Chip, where they are rightfully called label. Probably what happened here was a mixup between the tag naming convention (which uses tag.name, not tag.label) and MUI components (that do use the term "label").