search

codyswanner / Meme-Cataloger

Learning ReactJS and Django while building something that I want to use
1 stars 1 forks source link

Add "Edit" button for tags #71

Closed codyswanner closed 1 month ago

codyswanner commented 3 months ago

The LeftDrawer should have a caption at the top to indicate that the content is tags/filters, and an edit button that exposes a menu to delete/modify tags. (That menu should probably be a separate issue, this issue is only concerned with the new LeftDrawerCaption component that will label the filters/tags area and include an "edit" button.)

codyswanner commented 1 month ago

Working on this now -- I'm thinking it makes sense to have a separate "EditDrawer" module. I'm imagining that the checkboxes are replaced with little menu buttons for reordering, and on the right side X's come in for deleting the tag outright, and all the Typography components are replaced with text inputs (pre-populated with the current tag name) so that they can be altered as desired. Or, maybe it makes more sense to have each tag be a button that opens a dialog for renaming and deleting? Still brainstorming.

codyswanner commented 1 month ago

Maybe not the entire drawer needs to be mirrored in a new module... there is already a separate "DrawerContents" component, maybe that gets pulled out into it's own module, and then the "EditDrawerContents" module mirrors that but with edit options exposed. And maybe "FilterCheckbox" is mirrored in a "EditTag" (not in love with that name) module that replaces the checkboxes and converts the text to buttons, etc. Again, still thinking this over.

codyswanner commented 1 month ago

Addressed by #114