search

coecms / xmhw

Xarray version of Marine Heatwaves code by Eric Olivier
https://xmhw.readthedocs.io/en/latest/
Apache License 2.0
23 stars 10 forks source link

get_doy: creates a detached coordinate #1

Closed ccarouge closed 4 years ago

ccarouge commented 4 years ago

Change get_doy to work on the variable and attach the coordinate to the variable in the function instead of creating a detached array.

I decided to start with small details I come across as I get to know the code.

paolap commented 4 years ago

The detached array was because that day was potentially added to another array as well, so it was easier to have it. I'll have to check in the complete version (i.e. the one with detect) if that's still needed.

paolap commented 4 years ago

I've changed the name of the canton to add_doy to be consistent and merged the branch