search

coecms / xmhw

Xarray version of Marine Heatwaves code by Eric Olivier
https://xmhw.readthedocs.io/en/latest/
Apache License 2.0
22 stars 10 forks source link

generalised dimensions #6

Closed paolap closed 4 years ago

paolap commented 4 years ago

At the moment most of the code assumes 'time' as time dimensions and 'lat', 'Lon' as coordinates. We should allow coordinates to have different names.

Step 1: fix 'lat', 'lon' which are more likely to have a variety of names. Since lat/lon get stacked in cell at the start of the code, this should be relatively easy. If we can also allow an extra dimension as 'depth' then this could work on 4 D arrays too.

Step2: pass an extra argument tdim='time' to all the functions where this axis needs to be specified.

paolap commented 4 years ago

Step1 done, but I haven't add a test yet to land_check for this

paolap commented 4 years ago

Added test for land_check, step 2 done in detect branch commit: https://github.com/coecms/xmhw/commit/cf40c907aae7d6ffe413f69166eb7e604eb3c209