search

coelckers / prboom-plus

This is a cleaned up copy of the PrBoom+ SVN repository as a courtesy for those interested in forking that port
293 stars 117 forks source link

2s line midtexture vibration #505

Closed simc2 closed 2 years ago

simc2 commented 2 years ago

If there's a midtexture on a 2s line the texture will shiver or vibrate vertically if behind it there is a upper/lower texture from a moving ceiling/floor plane covering parts of the midtexture. That is when the midtexture is stationary or inmovable relative to the backside ceiling/floor movement.

A 10% speed gif animation of the effect: Untitled 4 (1)

This happens in Opelgl renderer only and when the uncapped framerate is on (default). Happens in both Prboom-plus, and DSDA-Doom.

Doesn't appear to happen in sw renderer or in opengl when the uncapped framerate is off. Also it doesn't happen to the midtexture on the same side than the moving plane.

A test wad for map01 Doom2. Should work if PrBoom-plus is run without config, Options > General >Video mode: opengl as the only change. texvibra.zip

JadingTsunami commented 2 years ago

PR with proposed fix in #507.

EDIT: I would like to add that the clarity and detail in this report was extremely helpful.

fabiangreffrath commented 2 years ago

https://github.com/coelckers/prboom-plus/commit/acd8ce1a426e9856026dbb5d4d51da4f0945e3f5