coelckers / prboom-plus

This is a cleaned up copy of the PrBoom+ SVN repository as a courtesy for those interested in forking that port
290 stars 117 forks source link

Add configurable reverb and chorus for PortMidi #530

Closed ceski-1 closed 2 years ago

ceski-1 commented 2 years ago

This PR adds the ability to configure two commonly adjusted settings: reverb and chorus. These values will work with any MIDI file that doesn't already set reverb or chorus, such as the original Doom 1 and 2 music. Otherwise, the MIDI file settings have priority.

The motivation behind this addition is that a reset sets the reverb to 40 and chorus to 0, per MIDI specifications. However, some users may prefer control over these values if they were used to a different setting before (see: https://github.com/fabiangreffrath/crispy-doom/issues/940).

New settings in prboom-plus.cfg:

mus_portmidi_reverb_level 40 (0 to 127) mus_portmidi_chorus_level 0 (0 to 127)