search

coelckers / prboom-plus

This is a cleaned up copy of the PrBoom+ SVN repository as a courtesy for those interested in forking that port
295 stars 118 forks source link

UMAPINFO: bring par times fix in line with Woof #537

Closed fabiangreffrath closed 2 years ago

fabiangreffrath commented 2 years ago

@rfomin @kraflab plausibility check, please. 😉

kraflab commented 2 years ago

I got a bit lost in the discussions about this issue. The only requirement from my side is that all the ports should still sync with demos recorded in ports that predate the fix. Is that the case?

rfomin commented 2 years ago

Looks good to me.

The only requirement from my side is that all the ports should still sync with demos recorded in ports that predate the fix. Is that the case?

Yes, I hope so. But I only tested it with a simple WAD that I made myself.

fabiangreffrath commented 2 years ago

This fix does two things:

  1. It adds the ability to set par times to the intermission screen that is shown if endpic is set but nointermission is not.
  2. It tracks if a par time has been set by means of UMAPINFO and makes sure it is shown on the intermission screen.
JadingTsunami commented 2 years ago

Overall looks good. I think the corner case of a UMAPINFO present, but no par time is set should be reviewed before we merge. The behavior here looks different to me.

fabiangreffrath commented 2 years ago

The only requirement from my side is that all the ports should still sync with demos recorded in ports that predate the fix. Is that the case?

What may happen is that a different par time is drawn on an intermission screen before an end pic, thus leading to a different point in time when the end pic appears.