search

coelckers / prboom-plus

This is a cleaned up copy of the PrBoom+ SVN repository as a courtesy for those interested in forking that port
290 stars 117 forks source link

Disable boss actions by default in non-vanilla episodes #549

Closed FozzeY closed 1 year ago

FozzeY commented 1 year ago

Fixes #482.

kraflab commented 1 year ago

This is a demo-compatibility-violating change as well as a change to the umapinfo specification. We cannot make such changes lightly.

kraflab commented 1 year ago

There are multiple fixes already in the linked issue, so I don't think this needs a code change.

JadingTsunami commented 1 year ago

Hmm, I'm not convinced this is an advisable change.

In the case this code addresses, the WAD author has supplied a UMAPINFO but did not supply bossaction(s). It would be a surprise in that case to override game-default behaviors as the UMAPINFO specification is explicit that the default is to defer to the original source code implementation.

I agree with @kraflab; this solution would be a UMAPINFO specification update, plus demo-breaking, and would need to be coordinated across all the ports at the same time. I also don't see the benefit here: if an author supplies a UMAPINFO, why not supply the explicit boss actions (or clear them) as intended?

The linked issue is a complaint about the source code behavior, not UMAPINFO, as I see it.

FozzeY commented 1 year ago

Fair enough.