coelckers / prboom-plus

This is a cleaned up copy of the PrBoom+ SVN repository as a courtesy for those interested in forking that port
295 stars 118 forks source link

Fix FluidSynth mode and polyphony #550

Closed ceski-1 closed 1 year ago

ceski-1 commented 1 year ago

This PR sets midi-bank-select and polyphony values to their defaults: gs and 256, respectively.

PrBoom+ used to have typos that meant default values were used for midi-bank-select and polyphony and that was fine. https://github.com/coelckers/prboom-plus/commit/495fd599b11283617bbc6ef966e7dbd709fc61c5 fixed the typos, so PrBoom+ started using poorly chosen values that cause notes to drop or cut out and disables GS features if a MIDI file uses them.

Download this: polyphony.zip

prboom-plus.exe -iwad doom2.wad -file polyphony.wad -warp 1

Listen to the trombone that plays in the left channel. If it cuts out, the polyphony is set too low.

References:

fabiangreffrath commented 1 year ago

Thank you!