search

coelckers / prboom-plus

This is a cleaned up copy of the PrBoom+ SVN repository as a courtesy for those interested in forking that port
290 stars 117 forks source link

PortMidi: Use channel volume control, remove extra delay after reset #552

Closed ceski-1 closed 1 year ago

ceski-1 commented 1 year ago
  1. Use channel volume control: Some devices don't support master volume messages. For best compatibility, volume control should be done using channel volume messages.
  2. Remove extra delay after reset: This is for SysEx resets from the MIDI file only. It's up to the composer to include a delay. If they didn't include one, they didn't intend for the song to play on retro hardware.
ceski-1 commented 1 year ago

That should do it. There's always something I'd like to change but the Woof/Chocolate features are outside the scope of PrBoom+ maintenance.

fabiangreffrath commented 1 year ago

Thank you for this! Are there any more changes to be expected to PrBoom+'s MIDI system?

ceski-1 commented 1 year ago

No, I'm done with PrBoom+. Feel free to ping if any bugs pop up or if there are any questions.