Implement articleRepliesFrom filter for ListArticles - Githubissues

cofacts / rumors-api

GraphQL API server for clients like rumors-site and rumors-line-bot

https://api.cofacts.tw

MIT License

111 stars 26 forks source link

Implement articleRepliesFrom filter for ListArticles #172

Closed MrOrz closed 4 years ago

MrOrz commented 4 years ago

Fixes #165

New Feature

Implements articleRepliesFrom in #165
- Drops appId because userId should be sufficient according to userId / appId management proposal
- I cannot think of any useful use case filtering article-reply's appId yet
Adds userId and appId to ListReplies filter, so that ListArticles, ListReplies filters work the same as ListArticleReplyFeedbacks's.

Refactor

Removes the limitation that requires userId and appId must be specified together in ListArticles filter
- Previously we use userId-appId pair to identify users. However in the future using only userId should be sufficient, thus removing the restriction here.

Bugfix

Fixes categoryIds and hasArticleReplyWithMorePositiveFeedback, which unions its results when used with other filters and is incorrect
- Similar to #171, please see #171 for explanation.

coveralls commented 4 years ago

Coverage increased (+0.4%) to 86.779% when pulling fd1630cafa6b24c83a82e76deccbd7a78214649c on user-filter into ce61fc150e8d63d61d4407ab43f88c1284864ecd on master.