Update rumors-db with analytics index mappings

cofacts / rumors-api

GraphQL API server for clients like rumors-site and rumors-line-bot

https://api.cofacts.tw

MIT License

109 stars 26 forks source link

Update rumors-db with analytics index mappings #195

Closed MrOrz closed 4 years ago

MrOrz commented 4 years ago

Update test/rumors-db submodule revision to include analytics index settings (cofacts/rumors-db#45)
Update unit test snapshot accordingly
- Mostly about index name change (alias --> real index name)
- Seems that elasticsearch is returning different order for indexes that has mappings. Not sure why, but I'll just accept that :P

coveralls commented 4 years ago

Coverage remained the same at 88.265% when pulling 266072b31385171e1b880898cdd3e6fa5a5b954e on rumors-db-update into a0a43a18523b0a595b15b48bef9a03c4102b8d73 on master.

MrOrz commented 4 years ago

Thanks for the review! Agree that we can add sorting in unit test to have more determinate snapshots.

If no other suggestions, I would like to merge this PR and deploy during midnights. Having these changes on staging and even production could benefit moedict hackathon tomorrow.