ListArticles categoryId filter fix - Githubissues

cofacts / rumors-api

GraphQL API server for clients like rumors-site and rumors-line-bot

https://api.cofacts.tw

MIT License

109 stars 26 forks source link

ListArticles categoryId filter fix #218

Closed MrOrz closed 3 years ago

MrOrz commented 3 years ago

Currently ListArticles(filter: {categoryId: [XXX]}) will include articles that has XXX even if

XXX has been deleted from the article, or
XXX receives more negative feedback than positive.

截圖 2020-09-13 下午7 36 11

This PR fixes the above scenario to make sure only articleCategories that is not deleted yet and has positive (or neutral) feedback are considered.

coveralls commented 3 years ago

Coverage remained the same at 88.666% when pulling 952c06f2d7540eb7c17faf856037e497147d9ce8 on fix-category-id-filter into 869bfcb4f24791793781f9a89d546d830e614fad on master.