search

cofacts / rumors-api

GraphQL API server for clients like rumors-site and rumors-line-bot
https://api.cofacts.tw
MIT License
109 stars 26 forks source link

[Trivial] expose user.appId for all users & all apps #241

Closed MrOrz closed 3 years ago

MrOrz commented 3 years ago

In the user profile page for LINE bot users, I want to tell site visitors that this user is from LINE and its username / avatar is randomly generated. Therefore, I would like to expose user's appId.

Currently I cannot think of reasons why we kept it for current user. No concern is documented in the design document either. This PR removes the restriction.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.05%) to 86.143% when pulling 760468d51b90546657fdee727232b582434937d6 on expose-user-appid into 9cf53b702f56c252cc19f9e0f7ccb818071d417b on master.