Fix build by upgrade Node.JS - Githubissues

cofacts / rumors-api

GraphQL API server for clients like rumors-site and rumors-line-bot

https://api.cofacts.tw

MIT License

109 stars 26 forks source link

Fix build by upgrade Node.JS #278

Closed MrOrz closed 2 years ago

MrOrz commented 2 years ago

When docker build the current master branch, docker image is broken because it is using node:12-alpine, whose npm is too old to properly load dependency from package-lock.json v2. This stops the server from booting:

This PR fixes the issue by

Updating Node.JS to v18 (with npm that can read v2 lockfile)
Update babel and remove unnecessary transform & shims
Fix pm2 start script (align with rumors-line-bot) to fix pid issue
Use @grpc/grpc-js to avoid native extension (native extension is very likely not provided and gyp always fail......)

coveralls commented 2 years ago

Coverage remained the same at 87.533% when pulling e0510ecbc74c7737663340ca8231664149005454 on fix-build-by-upgrade into 7b88fbe8f74bdba46575b9e4247427545095205e on master.