Apply media manager - Githubissues

cofacts / rumors-api

GraphQL API server for clients like rumors-site and rumors-line-bot

https://api.cofacts.tw

MIT License

109 stars 26 forks source link

Apply media manager #284

Closed MrOrz closed 2 years ago

MrOrz commented 2 years ago

Fixes #277

Remove Google Cloud Storage related logic because they are moved inside @cofacts/media-manager
- unit test mocks can be simplified because we can mock mediaManager method response directly, instead of mocking fetch and upload response separately
- We stopped storing attachmentUrl and resolve the value on-the-fly because we will be using signed URLs that may expire to prevent 盜連
ListArticles supports ranked list returned by mediaManager.query()

coveralls commented 2 years ago

Coverage decreased (-0.1%) to 87.355% when pulling 8dae1a06381ac702897c5f0d814c6c57c8facf11 on apply-media-manager into 319b9d3cef5efa151c82f1d9c73f1e35903cef22 on master.