search

cofacts / rumors-api

GraphQL API server for clients like rumors-site and rumors-line-bot
https://api.cofacts.tw
MIT License
112 stars 27 forks source link

Nullable createdat #324

Closed MrOrz closed 1 year ago

MrOrz commented 1 year ago

In 2023/10/25 pre-release test, we found that there are some articles not clickable on staging. GraphQL error shows that there are some article, article-reply and replies have no createdeAt. However, we set createdAt as non-null back in https://github.com/cofacts/rumors-api/pull/320

This PR removes the non-null restriction on createdAt for articles, replies and article-replies. 圖片

coveralls commented 1 year ago

Coverage Status

coverage: 88.365%. remained the same when pulling 5636d7aea151745bba7a37aebf130f329d9ff27c on nullable-createdat into 3a215c47079cbd88fff77d3e008d64a06a70430a on master.