search

cofacts / rumors-db

Scripts for managing rumors db
MIT License
5 stars 11 forks source link

Add migration script for analytics index #45

Closed MrOrz closed 4 years ago

MrOrz commented 4 years ago
  1. Add migration script for analytics index so that we can add the new index mapping to existing database
  2. Make db/loadSchema.js exit with non-zero return code so that Travis can capture the error when schema is invalid
  3. Fix typo in analytics index
MrOrz commented 4 years ago

Thanks for the review! I was also considering extracting the logic -- there is indeed a duplication, but migration scripts should be one-off and highly customized. Maybe we can leave it as-is for now and see if future occurrences suggest a more solid common pattern.