cofe-ai / fast-gector

Apache License 2.0
54 stars 11 forks source link

Questions about the code #10

Open sarrahbbh opened 1 year ago

sarrahbbh commented 1 year ago

Hello! First of all thank you for this implementation I'm currently trying to apply it on Arabic, and I have a few questions please if you could answer my curiosities, I would be super thankful!

  1. In the def get_target_sent_by_levels function, the very first edits level (level 0) is not considered hence the instruction rest_labels = label_list[1:], why is that? In my data, there's only one level of edits (one error per sentence), so is it wrong to take label_list[0:]?

  2. How is the labels vocab generated? should I just take the words that are included in my training data or can I use a vocabulary from another source? What would you recommend?

Sorry if my questions are too much! I just want to make sure that I'm training my model correctly Thank you so much in advance!