search

cofeman / go-charset

Automatically exported from code.google.com/p/go-charset
0 stars 0 forks source link

Move from os.ErrorString to os.NewError #2

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
To reflect recent Go API changes. 

I'm unable to do a merge request, don't know how that works on Google Code, 
here's the commit:

http://code.google.com/r/saschapeilicke-go-charset/source/detail?r=de31d93b0c0cf
dc8b7a617430bf595a85af1d93c

Original issue reported on code.google.com by sascha@peilicke.de on 25 Jun 2011 at 10:30

GoogleCodeExporter commented 8 years ago 
This one belongs to it too:
http://code.google.com/r/saschapeilicke-go-charset/source/detail?r=0d0d354c8e189
13fd850d868c16a839ff94beca9

Original comment by sascha@peilicke.de on 25 Jun 2011 at 10:51

GoogleCodeExporter commented 8 years ago 
Bump!

Original comment by omarshar...@gmail.com on 3 Aug 2011 at 7:09

GoogleCodeExporter commented 8 years ago 
sorry, i must have missed this earlier.
for the record, you can use the same code review mechanism for go-charset as 
for the
main go tree, but in this case the changes are so small i'll make them myself.

thanks for pointing it out.

Original comment by rogpeppe@gmail.com on 3 Aug 2011 at 9:08

GoogleCodeExporter commented 8 years ago 
"for the record, you can use the same code review mechanism for go-charset as 
for the
main go tree"

Sorry, not following you here, can you explain further?

Original comment by omarshar...@gmail.com on 3 Aug 2011 at 11:20

GoogleCodeExporter commented 8 years ago 
Expecting to see this 4-line change being made soon, as I am going to recommend 
this excellent package to some friends.

I guess it is not necessary, but anyway, here attaches a patch.

Original comment by Yi.Wang.2005 on 13 Aug 2011 at 2:07

Attachments:

GoogleCodeExporter commented 8 years ago 
sorry for the delay, i thought i'd submitted this ages ago!

Original comment by rogpeppe@gmail.com on 13 Aug 2011 at 2:42