search

coffee-tools / coffee

Reference implementation for a flexible core lightning plugin manager
https://docs.page/coffee-tools/coffee
9 stars 13 forks source link

allow the user to choose the branch/release of the plugin repository #131

Open vincenzopalazzo opened 1 year ago

vincenzopalazzo commented 1 year ago

Discussed in https://github.com/coffee-tools/coffee/discussions/130

Originally posted by **tareknaser360** May 10, 2023 Based on our earlier discussion, it was suggested to incorporate a new feature into upgrade command #43. Specifically, the proposed idea involves the addition of an option to select a specific branch or release of a remote repository, which can be specified by passing a flag. An example of the syntax for using this feature would be `coffee upgrade folgore --release 2.1` *It is important to note that this proposal assumes the presence of only one plugin in each remote repository.* I think such feature would improve the overall user experience.
tareknaser commented 1 year ago

A note that if a user updates the local repository to be a specific branch, we should keep the branch name stored so that if coffee upgrade repo was run again, the changes from that branch are pulled.

vincenzopalazzo commented 1 year ago

yeah I am start to think that we need a more powerful persistence, so I think I need to finish my implementation of https://github.com/vincenzopalazzo/nosql-db

vincenzopalazzo commented 1 year ago

@tareknaser we can open a issue for doing the same thing but for coffee install --branch ?

This should be also easy right?

tareknaser commented 1 year ago

This should be also easy right?

Yes this is straightforward