search

coffee-tools / coffee

Reference implementation for a flexible core lightning plugin manager
https://docs.page/coffee-tools/coffee
9 stars 13 forks source link

bad url inside the plugin struct in some cases #141

Closed vincenzopalazzo closed 1 year ago

vincenzopalazzo commented 1 year ago

While testing the https://github.com/coffee-tools/coffee/pull/134 we should find the cause and normalize the URL

I noted that the URL does not look right

{
  "plugins": [
    {
      "conf": null,
      "exec_path": "/tmp//.coffee/repositories/official/backup/backup.py",
      "lang": "PyPoetry",
      "name": "backup",
      "root_path": "/tmp//.coffee/repositories/official/backup"
    },
    {
      "conf": null,
      "exec_path": "/tmp//.coffee/repositories/official/summary/summary.py",
      "lang": "PyPip",
      "name": "summary",
      "root_path": "/tmp//.coffee/repositories/official/summary"
    }
  ]
}

there is an extra / in "exec_path": "/tmp//.coffee/repositories/official/backup/backup.py"

vincenzopalazzo commented 1 year ago

This can be solved by https://github.com/coffee-tools/coffee/pull/142#pullrequestreview-1451027324 but need to be tested in various test cases

tareknaser commented 1 year ago

Is this solved?

vincenzopalazzo commented 1 year ago

I do no know :) we should write a test for confirm