search

coffee-tools / coffee

Reference implementation for a flexible core lightning plugin manager
https://docs.page/coffee-tools/coffee
9 stars 13 forks source link

feat(core): implement the tip logic to pay a bolt 12 #181

Closed vincenzopalazzo closed 5 months ago

vincenzopalazzo commented 11 months ago

See commits for more details

Fixes https://github.com/coffee-tools/coffee/issues/137

netlify[bot] commented 11 months ago

Deploy Preview for coffee-docs canceled.

Name Link
Latest commit e2e6fc060cd54b7f891e0e3e979f32e413b2cc3d
Latest deploy log https://app.netlify.com/sites/coffee-docs/deploys/65c25cdcba3709000881e2ce
tareknaser commented 11 months ago

This command needs to be documented as well

vincenzopalazzo commented 11 months ago

I want to think how to test this

vincenzopalazzo commented 5 months ago

Based on top of the current master, and we are not ready to implement some tests inside our integration testing, sorry

vincenzopalazzo commented 5 months ago

Also, when I run coffee tip locally but the tip doesn't actually go through, I get an empty table in the output

How you are testing the coffee tip? What do you mean doesn't actually go through? What error you are getting?

tareknaser commented 5 months ago

How you are testing the coffee tip? What do you mean doesn't actually go through? What error you are getting?

That's the point I was making There is no error message if the payment doesn't go through but 7e11999a7355e63c9d1431ab8cec610a8c8ed650 added better error handling

vincenzopalazzo commented 5 months ago

but https://github.com/coffee-tools/coffee/commit/7e11999a7355e63c9d1431ab8cec610a8c8ed650 added better error handling

Yes I realize from your review that my implementation was a little bit monkey :)