search

coffee-tools / coffee

Reference implementation for a flexible core lightning plugin manager
https://docs.page/coffee-tools/coffee
9 stars 13 forks source link

use docker for default install #194

Open jackstar12 opened 1 year ago

jackstar12 commented 1 year ago

Currently default plugin installation is only implemented for pip and poetry, which is suboptimal.

Figuring this out for compiled languages would be pretty hard because you need to figure out how to detect / install each toolchain, which is why I propose using docker or podman (daemonless docker) for building the plugin into a container which cln can then run through a small generated script. Each language could have a default image or provide a custom one in coffee.yaml.

If docker / podman isn't installed on the machine we could still fallback to the current way of doing things.

I'd be willing to try implement this.

vincenzopalazzo commented 1 year ago

Currently default plugin installation is only implemented for pip and poetry, which is suboptimal.

Currently, with coffee.yml we support all the plugins, and I would like to see it as a standard because you can also have a missing python dir. but yeah you are right.

If docker / podman isn't installed on the machine we could still fallback to the current way of doing things.

Yeah correct, do you think that this required some change inside the coffee core? or it is possible to do just with coffee.yml?

I'd be willing to try implement this.

I would love to see it, please do if you need to chat more about it there is a Discussion open in the github repository

Thanks for this good point