search

coffee-tools / coffee

Reference implementation for a flexible core lightning plugin manager
https://docs.page/coffee-tools/coffee
9 stars 13 forks source link

fix(lib): simplify and improve sh! macro #195

Closed jackstar12 closed 10 months ago

jackstar12 commented 10 months ago

working on https://github.com/coffee-tools/coffee/issues/194 I noticed a issue with the sh macro when trying to execute a script that uses a pipe. Looking into the implementation I saw that it tries to manually parse out the commands, which is pretty error prone. so, instead of trying to manually parse the script and potentially making errors, let the actual sh command do the work correctly

netlify[bot] commented 10 months ago

Deploy Preview for coffee-docs canceled.

Name Link
Latest commit 785e8ac298c37ac945566b75a92815d37aabcd35
Latest deploy log https://app.netlify.com/sites/coffee-docs/deploys/64f5cc2a92771c0008f0eb87
vincenzopalazzo commented 10 months ago

@jackstar12 Are you still working on this? I would really love to merge went he review is addressed

jackstar12 commented 10 months ago

@jackstar12 Are you still working on this? I would really love to merge went he review is addressed

yes, I was on vacation this week, I`ll get to it in the next few days