search

coffee-tools / coffee

Reference implementation for a flexible core lightning plugin manager
https://docs.page/coffee-tools/coffee
9 stars 13 forks source link

we should move the repository directory inside a network directory #234

Open vincenzopalazzo opened 5 months ago

vincenzopalazzo commented 5 months ago

I try to run 

➜  ~ coffee --network testnet remote add folgore-git https://github.com/coffee-tools/folgore.git
✓ Remote added!
➜  ~ coffee remote add folgore-git https://github.com/coffee-tools/folgore.git
✗ Fetch remote from https://github.com/coffee-tools/folgore.git error: Error while add remote: code: 1, msg: repository with name: folgore-git already exists
✗ Error: code: 1, msg: repository with name: folgore-git already exists

This must not happen, because for each network we can add a different remote (e.g: a fork for testnet) so we should move the repository inside the network subdirectory

tareknaser commented 4 months ago

I am fully with this.

There are so many scenarios where this feature would come in handy. This would also be useful when we add coffee upgrade --branch <branch_name>

vincenzopalazzo commented 4 months ago

Yeah this si my fault that I tough that the repository was not needed as a network information