search

coffee-tools / coffee

Reference implementation for a flexible core lightning plugin manager
https://docs.page/coffee-tools/coffee
9 stars 13 forks source link

install command: add -T option to cp to not create nested folders on duplicate calls #243

Closed daywalker90 closed 4 months ago

daywalker90 commented 4 months ago

If you call coffee install more than once it will create folders like this:

  1. ~/.coffee//plugins/
  2. ~/.coffee//plugins//

the -T option for cp should fix this.

netlify[bot] commented 4 months ago

Deploy Preview for coffee-docs canceled.

Name Link
Latest commit 9ec10eaedcd814ecca49de8da0190198e6dc2a1f
Latest deploy log https://app.netlify.com/sites/coffee-docs/deploys/65db3de1efad3f000830944a
tareknaser commented 4 months ago

Just noticed that -T is a GNU cp feature and won't work on macOS.

Seems like kubernetes had a similar issue before https://github.com/kubernetes/kubernetes/issues/56383

vincenzopalazzo commented 4 months ago

Just noticed that -T is a GNU cp feature and won't work on macOS.

you had an OSX iirc? did you not test on your machine before approving the PR?

tareknaser commented 4 months ago

you had an OSX iirc? did you not test on your machine before approving the PR?

No I actually missed this one. I read the documentation for the flag online and thought it made perfect sense for a quick fix My bad