search

coffee-tools / coffee

Reference implementation for a flexible core lightning plugin manager
https://docs.page/coffee-tools/coffee
9 stars 13 forks source link

Network Validation in Command Line Inputs #270

Closed tareknaser closed 1 month ago

tareknaser commented 2 months ago

Description

Currently, coffee does not validate if the network supplied in the command line is valid. Running coffee -n remote list by mistake creates /Users/tareknasser/.coffee/remote

vincenzopalazzo commented 2 months ago

I did too :) we should validate the network is one of the cln supported one

Shoulds be really trivial

Anyitechs commented 2 months ago

Hi @vincenzopalazzo, I'll like to work on this issue.

vincenzopalazzo commented 2 months ago

@Anyitechs there is no need to ask or advertize that you are working on some issue, just open a PR

Anyitechs commented 2 months ago

@Anyitechs there is no need to ask or advertize that you are working on some issue, just open a PR

Ok. Thank you.

Anyitechs commented 2 months ago

Hi @vincenzopalazzo, I opened a draft PR here.

Let me know your thoughts.

cc: @tareknaser

vincenzopalazzo commented 2 months ago

Marking the commit as out of scope, please @Anyitechs do not use the github issue as a direct chat with the maintainer, if maintainer want to be reached they have an email in the github profile.