search

coffee-tools / coffee

Reference implementation for a flexible core lightning plugin manager
https://docs.page/coffee-tools/coffee
9 stars 13 forks source link

Add `coffee unlink` Command #279

Closed tareknaser closed 1 month ago

tareknaser commented 1 month ago

Description

This pull request adds the coffee unlink command and renames the coffee setup command to coffee link. Fixes #278

Changes

_Note: The commits are organized so that the renaming of coffee setup is in one commit, and the addition of coffee unlink is in a separate commit. The clightningrpc-conf from git is required to use the rm_subconf() method._

netlify[bot] commented 1 month ago

Deploy Preview for coffee-docs canceled.

Name Link
Latest commit c3f842ca5950f28a7c37ec56402c0d79e9c1ab65
Latest deploy log https://app.netlify.com/sites/coffee-docs/deploys/666323f825b4620008faa1cd
vincenzopalazzo commented 1 month ago

ops CI shows a break

    Checking brotli v3.4.0
   Compiling derive_more v0.99.17
error[E0282]: type annotations needed for `Box<_>`
Error:   --> /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.34/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
help: consider giving `items` an explicit type, where the placeholders `_` are specified
   |
83 |     let items: Box<_> = format_items
   |              ++++++++

   Compiling actix-router v0.5.2
For more information about this error, try `rustc --explain E0282`.
error: could not compile `time` (lib) due to 1 previous error
tareknaser commented 1 month ago

Hmmm It looks like the error is in the nightly build and appears to be a dependency issue, which doesn't seem related to this PR.

Update Just noticed I got the same error on master branch CI: https://github.com/tareknaser/coffee/actions/runs/9190931675/job/25276264891

Let me investigate this further