search

coffee-tools / coffee

Reference implementation for a flexible core lightning plugin manager
https://docs.page/coffee-tools/coffee
9 stars 13 forks source link

extract the coffe plugin manager from the coffe_cmd and move in a new crate #61

Closed vincenzopalazzo closed 1 year ago

vincenzopalazzo commented 1 year ago

Background

To run Coffe you are run the following command cargo run -- --help and you can run the following command to setup coffee for your core lightning node

cargo run -- setup <core lightning root path>
cargo run -- remote add lightningd https://github.com/lightningd/plugins.git
cargo run -- install <plugin_name>

However in order to implement https://github.com/coffee-tools/coffee/issues/60 and https://github.com/coffee-tools/coffee/issues/59 without code duplication we should move the coffee plugin manager implementation inside a new crater coffee_core to allow different kind of interface such as plugins and or web API.

Goal

The goal is to create a new rust crate with the name coffee_core and move the implementation of coffee inside this new crate. Then update the coffee_cmd to use this new crate

tareknaser commented 1 year ago

Should I just move coffee_cmd/src/coffee/mod.rs to the new crate or this and coffee_cmd/src/coffee/config.rs?

vincenzopalazzo commented 1 year ago

More or less yes, you should just move the coffee_cmd/src/coffee inside the coffee_core

vincenzopalazzo commented 1 year ago

@tareknaser360 are you planning to work on this? otherwise I can spend some time doing it.

It is a required step for some other issue

tareknaser commented 1 year ago

Yes. I will work on this.