coffeescript-cookbook / coffeescript-cookbook.github.io

CoffeeScript Recipes, Examples and Tutorials
https://coffeescript-cookbook.github.io
Other
562 stars 179 forks source link

New design is harmful to your health #31

Closed joaomoreno closed 13 years ago

joaomoreno commented 13 years ago

We needed to do something about the website's design, but this is not it.

Code boxes with too much contrast, regular text with too little, links are blue on blue, etc...

I propose to regress it to the original dark text on clear background design. All in favor say 'aye'.

JasonGiedymin commented 13 years ago

+1 on this.

I think at least for a while we stick with a generic layout and vote on prototypes.

Opinions form other commiters?

peterhellberg commented 13 years ago

Whoah! I’ve been on vacation over the extended weekend and return to this :(

I think we should revert back to the white/blue color scheme and then iterate over designs somewhere else.

JasonGiedymin commented 13 years ago

If any other commiters are reading this via email reply back (github lets you!)

Just voice a +/- 1

It helps to know where we all stand.

JohnFord commented 13 years ago

I agree that the contrast is a little low. Perhaps we can create a separate design/layout branch where those wanting to propose design changes can commit work for comments?

joefiorini commented 13 years ago

+1 - While I certainly appreciate the effort, I agree with @JasonGiedymin that we should vote on prototypes. It's important that the site look clean; readability and code formatting are key. Some responsive design would be good for anyone viewing on a mobile device.

blowmage commented 13 years ago

Ugh, where did my previous comment go? Dammit...

I tweaked the colors and text size a bit in e5d849e3. Does this fix the problems within the new look?

We don't need a vote. Feel free to create a branch and ask for feedback. Or just change it. You all have the commit bit for a reason.

JasonGiedymin commented 13 years ago

I'm pretty sure @joaomoreno has a different take on what I feel it should be. Both of which would be totally different than what you want as well.

So right after xyz user commits a new design, you commit a change, @joaomoreno will commit something different, and then I'll change it because I don't like it?

It would be an infinite loop unless we discuss it and agree on something.

This is exactly why projects with lots of commiters vote, so no one steps on each other's foot.

blowmage commented 13 years ago

So create a pull request or a branch and ask for feedback. If there is a consensus then you can use that to revert changes that go against it. I prefer action over words, and I appreciate someone taking the time to make a commit. But I dislike inflammatory language, which has no place in a project like this. (Harmful to your health? Really?)

I'm not interested in creating an organizational hierarchy here. Those with a commit bit are trusted. Treat others with respect and we won't need layers of bureaucracy.

joaomoreno commented 13 years ago

I totally subscribe to your actions over words boat, Mike. But I do get Jason's point in which going back and forth in a design change wave would take us nowhere. Some consensus on how it should look would do us some good.

High contrast between the background and the font burns your eyes more than otherwise. I had no intention whatsoever to offend the design nor the designer - it is only a funny comment on the comfort that your eyes should feel on a website design, and how I feel that the current design lacks that same comfort. I do understand how the title may look offensive though, sorry about that.

peterhellberg commented 13 years ago

I think we should also try to keep the vertical rhythm, and not change the size of fonts/marginals/padding without calculating the appropriate sizes.

I welcome all submissions but I think we should at least discuss major design/layout changes before pushing to the GitHub master branch?

I’m in full agreement with @blowmage that we should keep the project hierarchy flat.

blowmage commented 13 years ago

Sounds like we're all in agreement. A few hours ago we had no direction on design, and now it seems that folks are approaching consensus. I personally like the new design, and I find Solarized to be the opposite of "high contrast". But I have no problem moving to something better.

I would much rather see this discussion tied to something real, like a pull request or in a branch. So I'm closing this issue.

JohnFord commented 13 years ago

I created the site_design branch. My idea is that people can make UI changes in that, collaborate, etc... Once there's a quorum of consensus, the changes can be merged into master and published on the site. Unless otherwise directed, I'll amend the designer's instructions tonight with commands for switching branches, etc...