coffeine-labs / coffeine

Covariance Data Frames for Predictive M/EEG Pipelines
https://coffeine-labs.github.io/coffeine/
MIT License
33 stars 13 forks source link

ENH: make arithmetic mean for whitening in SPoC optional #49

Open dengemann opened 1 year ago

dengemann commented 1 year ago

The PyRiemann version of SPoC uses a Riemannian mean for computing the reference in SPoC. Our version uses an arithmetic mean. It should be optional.

DavidSabbagh commented 1 year ago

indeed but keeping the arithmetic mean as an option is important since it is much faster to compute and won't make a difference for most applications.

Le mer. 28 juin 2023 à 09:17, Denis A. Engemann @.***> a écrit :

The PyRiemann version of SPoC uses a Riemannian mean for computing the reference in SPoC. Our version uses an arithmetic mean. It should be optional.

— Reply to this email directly, view it on GitHub https://github.com/coffeine-labs/coffeine/issues/49, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIC2QGUKUYLJQFZ5OKHJC7TXNPK6ZANCNFSM6AAAAAAZWTIR7A . You are receiving this because you are subscribed to this thread.Message ID: @.***>